London9-OlehPysmenko-Week1#491
Conversation
| background-image: url("/HTML-CSS-Module-Project/img/first-background.jpg"); | ||
| height: 420px; | ||
| color:white; | ||
| padding-top: 250px; |
There was a problem hiding this comment.
Try to avoid using padding cause it could break on small screens.
Flexbox could help you out:
display: flex;
flex-direction: column;
justify-content: space-around;
space-around wil create three equal sections with spacing on top and bottom, and will be responsive
| margin-bottom: 2rem; | ||
| margin-top: 2rem; | ||
| padding-bottom: 0.5rem; | ||
| padding-left: 22%; |
There was a problem hiding this comment.
On small screen you can have this:
maybe text-align: center would make the job
| background-color: aquamarine; | ||
| } | ||
|
|
||
| .orderForm h2 { |
There was a problem hiding this comment.
this is a good reading about class naming convention. I was discovering myself as well while sending it 😄
| <title>Karma</title> | ||
| <link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'> | ||
| <link rel="stylesheet" href="css/normalize.css"> | ||
| <link rel="stylesheet" href="css/style.css"> |
There was a problem hiding this comment.
For some reason the stylesheet did not connect to the index.html. I was not sure why, if something is wrong with my VSCode or you need to make a change at your repo?
| @@ -1,19 +1,134 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Other than the only one issue I mentioned, I really liked your style of coding. It's logical, clear and neat.
3 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?